Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Add fatals and thread start/end events to timeline #2820

Merged
merged 18 commits into from
Nov 7, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Aug 29, 2024

Description

This PR will add timeline events for:

  • thread start
  • thread end
  • fatals (out-of-memory, out-of-time, division-by-zero, ... and any unhandled exception)

image

PROF-10117
PROF-10118
PROF-10119

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner August 29, 2024 13:58
@realFlowControl realFlowControl marked this pull request as draft August 29, 2024 13:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (b3fd817) to head (008a41a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2820   +/-   ##
=========================================
  Coverage     82.10%   82.10%           
  Complexity     2527     2527           
=========================================
  Files           108      108           
  Lines         10358    10358           
=========================================
  Hits           8504     8504           
  Misses         1854     1854           
Flag Coverage Δ
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fd817...008a41a. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2024

Benchmarks

Benchmark execution time: 2024-09-11 15:18:56

Comparing candidate commit 2d130a9 in PR branch florian/memory-limit-in-timline with baseline commit 186011f in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 9 unstable metrics.

scenario:walk_stack/1

  • 🟩 wall_time [-366.025ns; -361.991ns] or [-2.947%; -2.914%]

@realFlowControl realFlowControl force-pushed the florian/memory-limit-in-timline branch 5 times, most recently from a686d5e to 4450c03 Compare September 4, 2024 14:05
@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Sep 11, 2024
@realFlowControl realFlowControl marked this pull request as ready for review September 12, 2024 10:24
@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2024-11-06 14:26:25

Comparing candidate commit 008a41a in PR branch florian/memory-limit-in-timline with baseline commit b3fd817 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@realFlowControl realFlowControl merged commit a987853 into master Nov 7, 2024
713 of 726 checks passed
@realFlowControl realFlowControl deleted the florian/memory-limit-in-timline branch November 7, 2024 08:18
@realFlowControl realFlowControl self-assigned this Nov 7, 2024
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants