Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking from a hook is not stopping code execution #2836

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

Description

Blocking a request from Appsec should stop customer code execution. However, when this blocking happens within a tracer hook, it does not stop executing customer code execution.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana changed the title Replicate issue on a PHPT tests Blocking from a hook is not stopping code execution Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (c1fd94c) to head (78a05a9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2836      +/-   ##
============================================
+ Coverage     78.36%   80.91%   +2.54%     
  Complexity     2526     2526              
============================================
  Files           173      146      -27     
  Lines         18742    14711    -4031     
  Branches        976        0     -976     
============================================
- Hits          14688    11903    -2785     
+ Misses         3517     2808     -709     
+ Partials        537        0     -537     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1fd94c...78a05a9. Read the comment docs.

@bwoebi
Copy link
Collaborator

bwoebi commented Sep 5, 2024

I see, the tracer sandboxing is sandboxing the bailout away :-)
I suppose some it would be ideal to signal the tracer "please bailout again after catching this" :-D

@estringana estringana force-pushed the estringana/blocking-within-tracer-hook branch from c5d1d67 to 1d93a16 Compare September 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants