-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aws credentials to circleci system tests #2857
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
=========================================
Coverage 78.49% 78.49%
Complexity 2517 2517
=========================================
Files 173 173
Lines 18683 18683
Branches 975 975
=========================================
Hits 14665 14665
Misses 3481 3481
Partials 537 537
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
I sort-of don't really like having more secrets than needed in CI. What do we need aws credentials for, in system tests? |
@bwoebi We need AWS tests for correctly testing propagation between Lambda and messaging systems (SQS, SNS, Kinesis). The previous 3rd party software that we were using (Localstack) was not cutting it. It was not a 1 to 1 matchup of feature support compared to actual AWS, and was providing both false negatives and false positives for our tests. This change has already been made in the other tracers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's merge it.
But definitely first merge conti/fix-php-errors on the system-tests repo.
Description
add necessary auth for new aws system tests and add IDM scenarios of interest
Reviewer checklist