Skip to content

Commit

Permalink
fix(fastapi): do not use deprecated import path (#10652)
Browse files Browse the repository at this point in the history
Current code generates warning:
ddtrace.DDTraceDeprecationWarning:
ddtrace.contrib.asgi.middleware.__path__ is deprecated

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: erikayasuda <[email protected]>
  • Loading branch information
2 people authored and mabdinur committed Sep 25, 2024
1 parent 8a1af6e commit 02488bf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ddtrace/contrib/internal/fastapi/patch.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from ddtrace import Pin
from ddtrace import config
from ddtrace.appsec._iast._utils import _is_iast_enabled
from ddtrace.contrib.asgi.middleware import TraceMiddleware
from ddtrace.contrib.internal.asgi.middleware import TraceMiddleware
from ddtrace.contrib.internal.starlette.patch import _trace_background_tasks
from ddtrace.contrib.internal.starlette.patch import traced_handler
from ddtrace.internal.logger import get_logger
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/fix-warning-import-54de769abd54f7b6.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Updates import path in FastAPI module to use the new ASGI module location.

0 comments on commit 02488bf

Please sign in to comment.