Skip to content

Commit

Permalink
Merge branch 'main' into munir/fix-some-tracing-tests-1
Browse files Browse the repository at this point in the history
  • Loading branch information
mabdinur authored Aug 28, 2024
2 parents 2c2faa9 + acfda63 commit 9dbdd05
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 14 deletions.
11 changes: 0 additions & 11 deletions .circleci/config.templ.yml
Original file line number Diff line number Diff line change
Expand Up @@ -639,17 +639,6 @@ jobs:
pattern: 'opentelemetry'
snapshot: true

profile:
<<: *contrib_job
resource_class: large
# There are 32 jobs, so 2 per-node
parallelism: 16
steps:
- run_test:
# We don't want to run the profile-diff venvs
pattern: 'profile$'
trace_agent_url: ""

integration_agent:
<<: *machine_executor
parallelism: 2
Expand Down
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ ddtrace/profiling @DataDog/profiling-python
ddtrace/settings/profiling.py @DataDog/profiling-python
ddtrace/internal/datadog/profiling @DataDog/profiling-python
tests/profiling @DataDog/profiling-python
.gitlab/tests/profiling.yml @DataDog/profiling-python

# MLObs
ddtrace/llmobs/ @DataDog/ml-observability
Expand Down
3 changes: 2 additions & 1 deletion .gitlab/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,6 @@ variables:
include:
- local: ".gitlab/tests/appsec.yml"
- local: ".gitlab/tests/tracer.yml"
- local: ".gitlab/tests/core.yml"
- local: ".gitlab/tests/tracer.yml"
- local: ".gitlab/tests/profiling.yml"
6 changes: 6 additions & 0 deletions .gitlab/tests/profiling.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
profiling:
extends: .test_base_riot
parallel: 20
variables:
DD_TRACE_AGENT_URL: ""
SUITE_NAME: "profile$"
4 changes: 2 additions & 2 deletions tests/tracer/test_rate_limiter.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def test_rate_limiter_effective_rate_starting_rate(time_window):
assert limiter.current_window_ns == now_ns
assert limiter.prev_window_rate is None

# Gap of 0.9999 seconds, same window
time_ns = now_ns + (0.9999 * time_window)
# Gap of 0.85 seconds, same window
time_ns = now_ns + (0.85 * time_window)
with mock.patch("ddtrace.internal.rate_limiter.compat.monotonic_ns", return_value=time_ns):
assert limiter.is_allowed() is False
# DEV: We have rate_limit=1 set
Expand Down

0 comments on commit 9dbdd05

Please sign in to comment.