Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): revert rust rate limiter [backport 2.10] #10229

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

brettlangdon
Copy link
Member

Rust, just revert back to the original pure python rate limiter.

The impact here is fairly low, the Rust rate limiter is much faster, but this code isn't the slow part of a hot path, better to be safe than fast.

Fixes #10002

  • PR author has checked that all the criteria below are met

  • The PR description includes an overview of the change

  • The PR description articulates the motivation for the change

  • The change includes tests OR the PR description describes a testing strategy

  • The PR description notes risks associated with the change, if any

  • Newly-added code is easy to change

  • The change follows the library release note guidelines

  • The change includes or references documentation updates if necessary

  • Backport labels are set (if applicable)

  • Reviewer has checked that all the criteria below are met

  • Title is accurate

  • All changes are related to the pull request's stated goal

  • Avoids breaking API changes

  • Testing strategy adequately addresses listed risks

  • Newly-added code is easy to change

  • Release note makes sense to a user of the library

  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment

  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy

Rust, just revert back to the original pure python rate limiter.

The impact here is fairly low, the Rust rate limiter is much faster, but
this code isn't the slow part of a hot path, better to be safe than
fast.

Fixes #10002

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 5e8c0c0)
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 14, 2024

Datadog Report

Branch report: backport-10225-to-2.10
Commit report: 13f8719
Test service: dd-trace-py

✅ 0 Failed, 143690 Passed, 32780 Skipped, 9h 58m 28.8s Total duration (1h 42m 29.52s time saved)
⌛ 5 Performance Regressions

⌛ Performance Regressions vs Default Branch (5)

  • test_commit - test_kafka.py 1m 30.01s (+1m 26.61s, +2550%) - Details
  • test_no_propagation_via_env_var - test_tornado_web.py 3.76s (+3.05s, +427%)
  • test_schematized_operation_names[v0] - test_djangorestframework.py 6.82s (+5.54s, +433%)
  • test_schematized_operation_name[v1] - test_request.py 6.79s (+5.88s, +646%) - Details
  • test_schematized_service_name[None-mysvc] - test_request.py 5.78s (+4.87s, +533%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024

Benchmarks

Benchmark execution time: 2024-08-14 19:52:23

Comparing candidate commit 13f8719 in PR branch backport-10225-to-2.10 with baseline commit 5b2d1f8 in branch 2.10.

Found 1 performance improvements and 5 performance regressions! Performance is the same for 215 metrics, 9 unstable metrics.

scenario:otelspan-start

  • 🟩 max_rss_usage [-8.103MB; -8.063MB] or [-21.048%; -20.946%]

scenario:ratelimiter-defaults

  • 🟥 execution_time [+1.647µs; +1.680µs] or [+60.371%; +61.616%]

scenario:ratelimiter-high_rate_limit

  • 🟥 execution_time [+1.901µs; +1.942µs] or [+69.576%; +71.086%]

scenario:ratelimiter-long_window

  • 🟥 execution_time [+1.634µs; +1.669µs] or [+59.679%; +60.954%]

scenario:ratelimiter-low_rate_limit

  • 🟥 execution_time [+1.495µs; +1.528µs] or [+54.414%; +55.613%]

scenario:ratelimiter-short_window

  • 🟥 execution_time [+1.647µs; +1.679µs] or [+60.470%; +61.672%]

@brettlangdon brettlangdon merged commit 29d24e8 into 2.10 Aug 14, 2024
191 of 207 checks passed
@brettlangdon brettlangdon deleted the backport-10225-to-2.10 branch August 14, 2024 20:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.13793% with 15 lines in your changes missing coverage. Please review.

Project coverage is 10.21%. Comparing base (4d99cf0) to head (13f8719).
Report is 5 commits behind head on 2.10.

Files Patch % Lines
ddtrace/internal/rate_limiter.py 74.13% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             2.10   #10229       +/-   ##
===========================================
- Coverage   74.24%   10.21%   -64.04%     
===========================================
  Files        1332     1313       -19     
  Lines      126730   125126     -1604     
===========================================
- Hits        94096    12777    -81319     
- Misses      32634   112349    +79715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants