chore(tracing): drops support for v0.3 traces endpoint #10263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Datadog ReportBranch report: ✅ 0 Failed, 592 Passed, 694 Skipped, 19m 15.34s Total duration (17m 47.68s time saved) |
BenchmarksBenchmark execution time: 2024-09-23 16:53:20 Comparing candidate commit 6ff888f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 355 metrics, 48 unstable metrics. scenario:iast_aspects-aspect_iast_do_re_sub
|
mabdinur
commented
Aug 16, 2024
mabdinur
force-pushed
the
munir/remove-v03-encoder
branch
from
f87dc99
to
65efe34
Compare
mabdinur
commented
Sep 10, 2024
mabdinur
commented
Sep 10, 2024
mabdinur
commented
Sep 10, 2024
mabdinur
commented
Sep 12, 2024
ZStriker19
reviewed
Sep 12, 2024
ZStriker19
approved these changes
Sep 12, 2024
erikayasuda
approved these changes
Sep 13, 2024
emmettbutler
approved these changes
Sep 17, 2024
mabdinur
added a commit
that referenced
this pull request
Sep 25, 2024
## Description Currently the python tracer can submit traces to the `v0.3/traces` and `v0.4/tracer` endpoints in the Datadog Agent. The only difference between these endpoints is that `v0.4/traces` returns the agent sample rates (this is "priority sampling") while the response from `v0.3/traces` endpoint does not contain any sampling rates/configurations. With the removal of the dd_priority_sampling configuration in a previous PR user's can no longer disable agent based sampling in tracing clients. With this change we should deprecate the `v0.3/traces` endpoint and ensure it is never used. Instead the `v0.4` or `v0.5` endpoints should be used to submit traces to the agent. Follow up to: #10102 ## Changes - Removes `v0.3/traces` endpoint from the tracer AgentWriter. This endpoint is deprecated and will removed from the Agent soon******. - Removes all tests that submit traces to the `v0.3/traces` agent endpoint - Renames `v0.3` encoder to `v0.4` encoder (`v0.3/traces` and `v0.4/traces` agent endpoints have the same encoding format) Note: The minimum supported version of the datadog agent for ddtrace>=2.0 is [v7.28.0](https://ddtrace.readthedocs.io/en/stable/versioning.html?highlight=supported#release-support). This version of the datadog supports v0.4 and v0.5 trace endpoints. This is not a breaking change. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the python tracer can submit traces to the
v0.3/tracesandv0.4/tracerendpoints in the Datadog Agent. The only difference between these endpoints is thatv0.4/tracesreturns the agent sample rates (this is "priority sampling") while the response fromv0.3/tracesendpoint does not contain any sampling rates/configurations.With the removal of the dd_priority_sampling configuration in a previous PR user's can no longer disable agent based sampling in tracing clients. With this change we should deprecate the
v0.3/tracesendpoint and ensure it is never used. Instead thev0.4orv0.5endpoints should be used to submit traces to the agent.Follow up to: #10102
Changes
v0.3/tracesendpoint from the tracer AgentWriter. This endpoint is deprecated and will removed from the Agent soon******.v0.3/tracesagent endpointv0.3encoder tov0.4encoder (v0.3/tracesandv0.4/tracesagent endpoints have the same encoding format)Note: The minimum supported version of the datadog agent for ddtrace>=2.0 is v7.28.0. This version of the datadog supports v0.4 and v0.5 trace endpoints. This is not a breaking change.
Checklist
Reviewer Checklist