Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move internal suite to gitlab #10361

Merged
merged 40 commits into from
Aug 28, 2024
Merged

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Aug 23, 2024

This change moves the internal test suite from circleci to gitlab for billing purposes. There are a handful of tests that fail locally under this new configuration, because I can't figure out how to configure a docker-compose alias for the ddagent service that matches the alias that gitlab seems to require. I think this is an acceptable price to pay for the benefit this change provides.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners August 23, 2024 17:17
@emmettbutler emmettbutler marked this pull request as draft August 23, 2024 17:17
Copy link
Contributor

github-actions bot commented Aug 23, 2024

CODEOWNERS have been resolved as:

.gitlab/tests/core.yml                                                  @DataDog/python-guild @DataDog/apm-core-python
.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
tests/internal/test_serverless.py                                       @DataDog/apm-core-python
tests/telemetry/test_writer.py                                          @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 23, 2024

Datadog Report

Branch report: emmett.butler/internal-gitlab
Commit report: c20664a
Test service: dd-trace-py

✅ 0 Failed, 117907 Passed, 22692 Skipped, 3h 16m 10.73s Total duration (1m 55.19s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Benchmarks

Benchmark execution time: 2024-08-27 22:16:50

Comparing candidate commit 144b30f in PR branch emmett.butler/internal-gitlab with baseline commit 05b2bbe in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

@emmettbutler emmettbutler changed the title sketching internal suite in gitlab ci: move internal suite to gitlab Aug 27, 2024
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2024
@emmettbutler emmettbutler marked this pull request as ready for review August 27, 2024 17:52
@emmettbutler emmettbutler requested a review from a team as a code owner August 27, 2024 17:52
@emmettbutler
Copy link
Collaborator Author

@erikayasuda @brettlangdon this is reviewable

@emmettbutler emmettbutler enabled auto-merge (squash) August 27, 2024 18:28
.gitlab/tests/core.yml Outdated Show resolved Hide resolved
.gitlab/tests.yml Show resolved Hide resolved
tests/internal/test_serverless.py Show resolved Hide resolved
tests/internal/test_serverless.py Outdated Show resolved Hide resolved
.gitlab/tests/core.yml Outdated Show resolved Hide resolved
@emmettbutler emmettbutler merged commit 12655ee into main Aug 28, 2024
256 of 257 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/internal-gitlab branch August 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants