Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set testrunner timeout to 20m #10406

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Aug 27, 2024

Right now the default is 1h.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner August 27, 2024 15:24
@brettlangdon
Copy link
Member Author

20m might be too aggressive? I think most jobs finish in <10m

@brettlangdon brettlangdon enabled auto-merge (squash) August 27, 2024 15:24
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2024

Benchmarks

Benchmark execution time: 2024-08-27 15:59:54

Comparing candidate commit 7748cd2 in PR branch brettlangdon/job.timeout with baseline commit 70ed1a4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@brettlangdon brettlangdon merged commit 3569551 into main Aug 28, 2024
161 of 162 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/job.timeout branch August 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants