Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): fastapi path parameter support #10426

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Aug 28, 2024

Path parameter sources

Previous sources tasks:

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Aug 28, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 28, 2024

Datadog Report

Branch report: avara1986/APPSEC-54622-iast_path_parameter
Commit report: 7829939
Test service: dd-trace-py

✅ 0 Failed, 122390 Passed, 15214 Skipped, 3h 17m 7.55s Total duration (1m 10.98s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Benchmarks

Benchmark execution time: 2024-08-30 14:17:45

Comparing candidate commit 7829939 in PR branch avara1986/APPSEC-54622-iast_path_parameter with baseline commit 5b394f1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@avara1986 avara1986 marked this pull request as ready for review August 28, 2024 14:51
@avara1986 avara1986 requested review from a team as code owners August 28, 2024 14:51
@avara1986 avara1986 enabled auto-merge (squash) August 30, 2024 07:35
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_patch.py                                          @DataDog/asm-python
ddtrace/contrib/internal/starlette/patch.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/fastapi/test_fastapi_appsec_iast.py                       @DataDog/asm-python

ddtrace/appsec/_iast/_patch.py Outdated Show resolved Hide resolved
@avara1986 avara1986 merged commit 62bb903 into main Aug 30, 2024
266 of 268 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-54622-iast_path_parameter branch August 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants