Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test merge queue #10429

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: test merge queue #10429

merged 1 commit into from
Aug 28, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Aug 28, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 28, 2024
@erikayasuda erikayasuda requested a review from a team as a code owner August 28, 2024 14:53
@erikayasuda erikayasuda requested review from emmettbutler and removed request for a team and emmettbutler August 28, 2024 14:53
@erikayasuda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@erikayasuda
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@erikayasuda erikayasuda added this pull request to the merge queue Aug 28, 2024
Merged via the queue into test-mq-main with commit aacb623 Aug 28, 2024
185 of 190 checks passed
@erikayasuda erikayasuda deleted the erikayasuda/test-mq-2 branch August 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant