Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: TEST mq needs conditionals #10434

Closed
wants to merge 1 commit into from
Closed

chore: TEST mq needs conditionals #10434

wants to merge 1 commit into from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Aug 28, 2024 •
edited
Loading

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda requested review from a team as code owners August 28, 2024 18:28
@erikayasuda erikayasuda requested review from gnufede and emmettbutler and removed request for a team, gnufede and emmettbutler August 28, 2024 18:28
@erikayasuda erikayasuda added this pull request to the merge queue Aug 28, 2024
@erikayasuda erikayasuda removed this pull request from the merge queue due to a manual request Aug 28, 2024
@erikayasuda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 28, 2024
@erikayasuda
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@erikayasuda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.

Use /merge -c to cancel this operation!

@erikayasuda
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Sep 4, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Sep 4, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@erikayasuda erikayasuda closed this Sep 4, 2024
@erikayasuda erikayasuda deleted the erikayasuda/mq-required-status branch September 11, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikayasuda