Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): add more leak testing to CI #10465

Merged
merged 25 commits into from
Sep 13, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Aug 30, 2024

Description

Reuse (with some refactoring) the existing leak testing script to add it's funcionality as a new CI step. Also adds some command line arguments to the script to configure it's behaviour and ensures no dependency on the running shell environment.

Signed-off-by: Juanjo Alvarez [email protected]

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Aug 30, 2024
@juanjux juanjux self-assigned this Aug 30, 2024
@juanjux juanjux requested a review from a team as a code owner August 30, 2024 16:51
Copy link
Contributor

github-actions bot commented Aug 30, 2024

CODEOWNERS have been resolved as:

tests/appsec/iast_aggregated_memcheck/__init__.py                       @DataDog/asm-python
tests/appsec/iast_aggregated_memcheck/test_aggregated_memleaks.py       @DataDog/asm-python
.gitlab/tests/appsec.yml                                                @DataDog/asm-python
hatch.toml                                                              @DataDog/python-guild
scripts/iast/mod_leak_functions.py                                      @DataDog/asm-python
scripts/iast/test_leak_functions.py                                     @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 30, 2024

Datadog Report

Branch report: juanjux/better-leak-script-and-testing
Commit report: a307f58
Test service: dd-trace-py

✅ 0 Failed, 3514 Passed, 3195 Skipped, 36m 1.49s Total duration (1h 2m 6.59s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 30, 2024

Benchmarks

Benchmark execution time: 2024-09-13 10:43:52

Comparing candidate commit a307f58 in PR branch juanjux/better-leak-script-and-testing with baseline commit ff2206a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 354 metrics, 46 unstable metrics.

@juanjux juanjux requested a review from a team as a code owner September 2, 2024 08:21
@juanjux juanjux closed this Sep 2, 2024
@juanjux juanjux reopened this Sep 2, 2024
@juanjux
Copy link
Collaborator Author

juanjux commented Sep 3, 2024

Moved back to draft until I can fix the timeouts in the new test.

@juanjux juanjux marked this pull request as draft September 3, 2024 07:14
@juanjux juanjux marked this pull request as ready for review September 13, 2024 09:55
@juanjux juanjux requested a review from a team as a code owner September 13, 2024 09:55
@juanjux juanjux requested a review from tabgok September 13, 2024 09:55
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux enabled auto-merge (squash) September 13, 2024 11:28
@juanjux juanjux merged commit 094aa66 into main Sep 13, 2024
632 checks passed
@juanjux juanjux deleted the juanjux/better-leak-script-and-testing branch September 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants