Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable merge_group trigger for status checks required in merge queue #10515

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Sep 4, 2024

Prior to enabling the merge queue, we need to add the merge_group trigger for the status checks that are required for the merge queue (which is going to be all status checks). Without this, the status checks will hang once the PR is at the head of the queue.

This PR will NOT enable the merge queue itself. This is a prerequisite step that is required for the merge queue to work properly.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 4, 2024

CODEOWNERS have been resolved as:

.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/codeql-analysis.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/django-overhead-profile.yml                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/encoders-profile.yml                                  @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/flask-overhead-profile.yml                            @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/pypa_musllinux_1_2_i686.yml                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/requirements-locks.yml                                @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/rust-ci.yml                                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/testrunner.yml                                        @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/unit_tests.yml                                        @DataDog/python-guild @DataDog/apm-core-python

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 4, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-11 19:49:00

Comparing candidate commit 27a0610 in PR branch erikayasuda/enable-merge-group-trigger with baseline commit 9e13d95 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@erikayasuda erikayasuda closed this Sep 6, 2024
@erikayasuda erikayasuda reopened this Sep 6, 2024
@erikayasuda erikayasuda enabled auto-merge (squash) September 6, 2024 17:52
@erikayasuda erikayasuda merged commit 6de80fb into main Sep 11, 2024
543 of 546 checks passed
@erikayasuda erikayasuda deleted the erikayasuda/enable-merge-group-trigger branch September 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants