Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsm): implement protobuf schema tracking #10587

Merged
merged 55 commits into from
Sep 12, 2024

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Sep 10, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

wconti27 and others added 30 commits August 29, 2024 10:37
…og/dd-trace-py into conti/implement-dsm-schema-support
…og/dd-trace-py into conti/implement-dsm-schema-support
@wconti27 wconti27 changed the title Conti/implement protobuf schemas feat(dsm): implement protobuf schema tracking Sep 10, 2024
@wconti27 wconti27 changed the base branch from main to conti/implement-avro-schemas September 10, 2024 13:34
Copy link
Contributor

github-actions bot commented Sep 10, 2024

CODEOWNERS have been resolved as:

.riot/requirements/1721018.txt                                          @DataDog/apm-python
.riot/requirements/1bf9721.txt                                          @DataDog/apm-python
.riot/requirements/26aada0.txt                                          @DataDog/apm-python
.riot/requirements/3b28562.txt                                          @DataDog/apm-python
.riot/requirements/e222783.txt                                          @DataDog/apm-python
ddtrace/contrib/internal/protobuf/__init__.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/protobuf/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/protobuf/schema_iterator.py                    @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/protobuf/__init__.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python
releasenotes/notes/implement-schema-tracking-for-protobuf-adf8e0ffe3c057f5.yaml  @DataDog/apm-python
tests/contrib/protobuf/__init__.py                                      @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/conftest.py                                      @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/schemas/__init__.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/schemas/message.proto                            @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/schemas/message_pb2.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/schemas/other_message.proto                      @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/schemas/other_message_pb2.py                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/protobuf/test_protobuf.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
.gitlab/tests/contrib.yml                                               @DataDog/python-guild @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/.suitespec.json                                                   @DataDog/python-guild @DataDog/apm-core-python

Base automatically changed from conti/implement-avro-schemas to main September 10, 2024 14:08
@pr-commenter
Copy link

pr-commenter bot commented Sep 10, 2024

Benchmarks

Benchmark execution time: 2024-09-12 16:38:49

Comparing candidate commit 9f31466 in PR branch conti/implement-protobuf-schemas with baseline commit c06246f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@wconti27 wconti27 marked this pull request as ready for review September 10, 2024 15:18
@wconti27 wconti27 requested review from a team as code owners September 10, 2024 15:18
@wconti27 wconti27 added this pull request to the merge queue Sep 12, 2024
@erikayasuda erikayasuda removed this pull request from the merge queue due to a manual request Sep 12, 2024
@wconti27 wconti27 merged commit 11e5829 into main Sep 12, 2024
515 checks passed
@wconti27 wconti27 deleted the conti/implement-protobuf-schemas branch September 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants