Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move suites that use httpbin_local to gitlab from circleci #10601

Merged
merged 12 commits into from
Sep 11, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Sep 10, 2024

This change moves test suites that use the httpbin_local service from circleci to gitlab for billing purposes.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 10, 2024

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests/contrib.yml                                               @DataDog/python-guild @DataDog/apm-core-python
tests/contrib/aiohttp/test_aiohttp_client.py                            @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/requests/test_requests.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 10, 2024
@emmettbutler emmettbutler requested a review from a team as a code owner September 10, 2024 17:13
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 10, 2024

Datadog Report

Branch report: emmett.butler/gitlab-httpbinlocal
Commit report: f68ab4a
Test service: dd-trace-py

✅ 0 Failed, 3593 Passed, 3395 Skipped, 36m 48.94s Total duration (1h 6m 5.31s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 10, 2024

Benchmarks

Benchmark execution time: 2024-09-11 15:21:52

Comparing candidate commit f68ab4a in PR branch emmett.butler/gitlab-httpbinlocal with baseline commit 65c838b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

.gitlab/tests/contrib.yml Show resolved Hide resolved
@emmettbutler emmettbutler enabled auto-merge (squash) September 10, 2024 19:19
@emmettbutler emmettbutler merged commit 72f4032 into main Sep 11, 2024
510 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/gitlab-httpbinlocal branch September 11, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants