Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): fix a flaky test #10636

Merged
merged 4 commits into from
Sep 11, 2024
Merged

chore(profiling): fix a flaky test #10636

merged 4 commits into from
Sep 11, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Sep 11, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner September 11, 2024 17:45
@taegyunkim taegyunkim added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels Sep 11, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/profiling-v2/collector/test_threading.py                          @DataDog/profiling-python

@taegyunkim taegyunkim changed the title chore(profiling): fix a flaky test chore(profiling): fix a flaky test Sep 11, 2024
@taegyunkim taegyunkim enabled auto-merge (squash) September 11, 2024 18:18
@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2024

Benchmarks

Benchmark execution time: 2024-09-11 18:36:25

Comparing candidate commit f352579 in PR branch taegyunkim/dummy-thread with baseline commit 0c3f334 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim merged commit 9e13d95 into main Sep 11, 2024
481 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/dummy-thread branch September 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants