Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asm): fixing exploit prevention on custom redirect action [backport 2.11] #10654

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2024

Backport 69c090b from #10644 to 2.11.

Check for redirecting actions as well for blocking requests with exploit prevention.

Also add regression tests in threat tests.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Check for redirecting actions as well for blocking requests with exploit
prevention.

Also add regression tests in threat tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 69c090b)
@github-actions github-actions bot requested a review from a team as a code owner September 13, 2024 13:03
@github-actions github-actions bot added the bug label Sep 13, 2024
@github-actions github-actions bot requested a review from a team as a code owner September 13, 2024 13:03
@github-actions github-actions bot added the ASM Application Security Monitoring label Sep 13, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 13, 2024

Datadog Report

Branch report: backport-10644-to-2.11
Commit report: 8105ab3
Test service: dd-trace-py

✅ 0 Failed, 113016 Passed, 875 Skipped, 37m 0.62s Total duration (5m 45.09s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.56%. Comparing base (9c353ce) to head (8105ab3).
Report is 42 commits behind head on 2.11.

Additional details and impacted files
@@             Coverage Diff             @@
##             2.11   #10654       +/-   ##
===========================================
- Coverage   34.18%   10.56%   -23.62%     
===========================================
  Files        1385     1386        +1     
  Lines      129280   129552      +272     
===========================================
- Hits        44191    13691    -30500     
- Misses      85089   115861    +30772     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Sep 13, 2024

Benchmarks

Benchmark execution time: 2024-09-13 13:39:40

Comparing candidate commit 8105ab3 in PR branch backport-10644-to-2.11 with baseline commit 81cde40 in branch 2.11.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

@christophe-papazian christophe-papazian merged commit 3a34274 into 2.11 Sep 13, 2024
188 of 192 checks passed
@christophe-papazian christophe-papazian deleted the backport-10644-to-2.11 branch September 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants