Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asm): fixing exploit prevention on custom redirect action [backport 2.13] #10656

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2024

Backport 69c090b from #10644 to 2.13.

Check for redirecting actions as well for blocking requests with exploit prevention.

Also add regression tests in threat tests.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Check for redirecting actions as well for blocking requests with exploit
prevention.

Also add regression tests in threat tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 69c090b)
@github-actions github-actions bot added bug ASM Application Security Monitoring labels Sep 13, 2024
@github-actions github-actions bot requested review from a team as code owners September 13, 2024 13:03
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 13, 2024

Datadog Report

Branch report: backport-10644-to-2.13
Commit report: bd8beb3
Test service: dd-trace-py

✅ 0 Failed, 1947 Passed, 212 Skipped, 1m 50.54s Total duration (1m 34.95s time saved)

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Sep 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 13, 2024

Benchmarks

Benchmark execution time: 2024-09-13 13:44:14

Comparing candidate commit bd8beb3 in PR branch backport-10644-to-2.13 with baseline commit ccb0932 in branch 2.13.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

auto-merge was automatically disabled September 13, 2024 13:47

Pull request was closed

Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/fix_exploit_prevention_on_redirection-fc2c0c73abb50b7b.yaml  @DataDog/apm-python
tests/appsec/appsec/rules-rasp-redirecting.json                         @DataDog/asm-python
ddtrace/appsec/_common_module_patches.py                                @DataDog/asm-python
tests/appsec/contrib_appsec/utils.py                                    @DataDog/asm-python
tests/appsec/rules.py                                                   @DataDog/asm-python

@christophe-papazian christophe-papazian merged commit 144cf17 into 2.13 Sep 13, 2024
453 of 455 checks passed
@christophe-papazian christophe-papazian deleted the backport-10644-to-2.13 branch September 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant