Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: system-tests integrations and messaging tests #10670

Merged
merged 11 commits into from
Sep 20, 2024

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Sep 16, 2024

Messaging / DSM tests now require AWS

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wconti27 wconti27 requested review from a team as code owners September 16, 2024 13:15
@wconti27 wconti27 changed the title fix: fix system-tests integrations and messaging tests fix: system-tests integrations and messaging tests Sep 16, 2024
@wconti27 wconti27 self-assigned this Sep 16, 2024
@wconti27 wconti27 added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 16, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 16, 2024

Benchmarks

Benchmark execution time: 2024-09-19 22:00:06

Comparing candidate commit cdffab7 in PR branch conti/fix-system-tests with baseline commit fe5b42f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@wconti27 wconti27 changed the title fix: system-tests integrations and messaging tests fix: system-tests integrations and messaging tests Sep 17, 2024
@wconti27 wconti27 changed the title fix: system-tests integrations and messaging tests chore: system-tests integrations and messaging tests Sep 17, 2024
@wconti27 wconti27 enabled auto-merge (squash) September 19, 2024 21:01
@wconti27 wconti27 merged commit baac738 into main Sep 20, 2024
615 checks passed
@wconti27 wconti27 deleted the conti/fix-system-tests branch September 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants