Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [SVLS-5262] move private Span Pointers to a new file #10684

Merged

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Sep 17, 2024

In preparation for future work, let's move the private span pointer code out to its own file.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@apiarian-datadog apiarian-datadog added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

CODEOWNERS have been resolved as:

ddtrace/_trace/_span_pointer.py                                         @DataDog/apm-sdk-api-python
ddtrace/_trace/_span_link.py                                            @DataDog/apm-sdk-api-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-api-python
tests/tracer/test_encoders.py                                           @DataDog/apm-sdk-api-python
tests/tracer/test_span.py                                               @DataDog/apm-sdk-api-python

@apiarian-datadog apiarian-datadog changed the title [SVLS-5262] move private Span Pointers to a new file chore: [SVLS-5262] move private Span Pointers to a new file Sep 17, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 17, 2024

Datadog Report

Branch report: aleksandr.pasechnik/svls-5262-1-extract-span-pointers
Commit report: 4534d8c
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 37m 7.16s Total duration (1m 21.48s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2024

Benchmarks

Benchmark execution time: 2024-09-19 13:54:30

Comparing candidate commit 4534d8c in PR branch aleksandr.pasechnik/svls-5262-1-extract-span-pointers with baseline commit aef5bc0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 319 metrics, 47 unstable metrics.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5262-1-extract-span-pointers branch from cb879b9 to ba17d2a Compare September 17, 2024 18:04
@apiarian-datadog apiarian-datadog marked this pull request as ready for review September 17, 2024 19:02
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner September 17, 2024 19:02
ddtrace/_trace/_span_pointer.py Outdated Show resolved Hide resolved
@ZStriker19 ZStriker19 enabled auto-merge (squash) September 18, 2024 15:37
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5262-1-extract-span-pointers branch from 1d95cca to bd84ac8 Compare September 19, 2024 13:10
@ZStriker19 ZStriker19 merged commit 05bc8d1 into main Sep 19, 2024
639 of 640 checks passed
@ZStriker19 ZStriker19 deleted the aleksandr.pasechnik/svls-5262-1-extract-span-pointers branch September 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants