-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kafka): cast topic to str since it can return None #10691
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 592 Passed, 604 Skipped, 19m 4.8s Total duration (17m 43.61s time saved) |
BenchmarksBenchmark execution time: 2024-09-20 15:38:06 Comparing candidate commit 8464af9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 348 metrics, 48 unstable metrics. |
Since topic can be None for a message object we should always cast it to a str or else it'll throw an error if we try to set it as a tag with set_tag_str
https://docs.confluent.io/platform/current/clients/confluent-kafka-python/html/index.html#confluent_kafka.Message.topic
Checklist
Reviewer Checklist