Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add system-tests finished job #10699

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Sep 18, 2024

This job will always run, but will only succeed if the entire workflow is successful, or fail if any part of the workflow failed

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python

This job will always run, but will only succeed if the entire workflow is successful, or fail if any part of the workflow failed
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Benchmark execution time: 2024-09-20 00:08:32

Comparing candidate commit 3cf0048 in PR branch brettlangdon/system-tests.all with baseline commit bd0db4c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@brettlangdon brettlangdon marked this pull request as ready for review September 19, 2024 14:17
@brettlangdon brettlangdon requested review from a team as code owners September 19, 2024 14:17
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 19, 2024
@brettlangdon brettlangdon enabled auto-merge (squash) September 19, 2024 23:31
@brettlangdon brettlangdon merged commit 3fc23d7 into main Sep 20, 2024
616 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/system-tests.all branch September 20, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants