Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): add language tag to span events [backport 2.13] #10704

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport b488c99 from #10681 to 2.13.

Adds a language:python tag to all LLMObs span events, to be used for internal analysis. No changelog needed since this isn't a user-facing functional change or fix (it will just show as an extra tag in the UI).

MLOB-1543

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Adds a `language:python` tag to all LLMObs span events, to be used for
internal analysis. No changelog needed since this isn't a user-facing
functional change or fix (it will just show as an extra tag in the UI).

(cherry picked from commit b488c99)
@github-actions github-actions bot requested a review from a team as a code owner September 18, 2024 12:49
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 18, 2024
@sabrenner sabrenner enabled auto-merge (squash) September 18, 2024 12:51
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 18, 2024

Datadog Report

Branch report: backport-10681-to-2.13
Commit report: ab7fb99
Test service: dd-trace-py

✅ 0 Failed, 955 Passed, 0 Skipped, 14m 47.69s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Benchmark execution time: 2024-09-18 13:29:08

Comparing candidate commit 9220ba1 in PR branch backport-10681-to-2.13 with baseline commit eea8ed6 in branch 2.13.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/llmobs/_trace_processor.py                                      @DataDog/ml-observability
tests/llmobs/_utils.py                                                  @DataDog/ml-observability

@sabrenner sabrenner merged commit efb3c0e into 2.13 Sep 20, 2024
435 of 454 checks passed
@sabrenner sabrenner deleted the backport-10681-to-2.13 branch September 20, 2024 14:01
sabrenner added a commit that referenced this pull request Sep 24, 2024
sabrenner added a commit that referenced this pull request Sep 30, 2024
…]" (#10793)

Reverts #10704
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant