Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): fix flaky tests #10721

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Sep 19, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested a review from a team as a code owner September 19, 2024 18:35
@mabdinur mabdinur changed the title chore(telemetry): unskip all tests chore(telemetry): remove pytest.skip from tests Sep 19, 2024
@mabdinur mabdinur changed the title chore(telemetry): remove pytest.skip from tests chore(telemetry): remove pytest.mark.skip from tests Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

CODEOWNERS have been resolved as:

tests/telemetry/test_writer.py                                          @DataDog/apm-core-python
tests/tracer/test_processors.py                                         @DataDog/apm-sdk-api-python

Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe update the PR title to be a bit more specific? Otherwise LGTM

Comment on lines -388 to -391
import string

new_deps = [string.__name__]
telemetry_writer._app_dependencies_loaded_event(new_deps)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the fix for this test is to make the app-dependencies-loaded event get triggered indirectly via an actual import statement instead of explicitly like this?

tests/telemetry/test_writer.py Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2024

Benchmarks

Benchmark execution time: 2024-09-20 18:26:24

Comparing candidate commit 732462b in PR branch munir/fix-telemetry-flakies with baseline commit 742a579 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@mabdinur mabdinur changed the title chore(telemetry): remove pytest.mark.skip from tests chore(telemetry): fix flaky tests Sep 20, 2024
@mabdinur mabdinur requested a review from a team as a code owner September 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants