-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(telemetry): fix flaky tests #10721
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe update the PR title to be a bit more specific? Otherwise LGTM
import string | ||
|
||
new_deps = [string.__name__] | ||
telemetry_writer._app_dependencies_loaded_event(new_deps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the fix for this test is to make the app-dependencies-loaded
event get triggered indirectly via an actual import statement instead of explicitly like this?
BenchmarksBenchmark execution time: 2024-09-20 18:26:24 Comparing candidate commit 732462b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
Co-authored-by: erikayasuda <[email protected]>
Checklist
Reviewer Checklist