Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crashtracking): add python version to crashtracker tags [backport 2.11] #10731

Open
wants to merge 2 commits into
base: 2.11
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 19, 2024

Backport fe5b42f from #10720 to 2.11.

During escalations it's currently difficult to find the exact Python version relevant for a defect. This is a simple fix for that.

I'm recommending a backport because

  1. The fix is simple
  2. 2.11 and onward introduce crashtracker, and we're still dealing with crashes from those versions

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

During escalations it's currently difficult to find the exact Python
version relevant for a defect. This is a simple fix for that.

I'm recommending a backport because
1. The fix is simple
2. 2.11 and onward introduce crashtracker, and we're still dealing with
crashes from those versions

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [X] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit fe5b42f)
@github-actions github-actions bot requested a review from a team as a code owner September 19, 2024 21:23
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 19, 2024
@taegyunkim taegyunkim enabled auto-merge (squash) September 19, 2024 21:28
@taegyunkim taegyunkim closed this Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 21:28

Pull request was closed

@taegyunkim taegyunkim reopened this Sep 19, 2024
@taegyunkim taegyunkim enabled auto-merge (squash) September 19, 2024 21:29
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 19, 2024

Datadog Report

Branch report: backport-10720-to-2.11
Commit report: 649de48
Test service: dd-trace-py

❌ 2 Failed (0 Known Flaky), 176166 Passed, 2443 Skipped, 11h 4m 17.75s Total duration (1h 27m 12.05s time saved)

❌ Failed Tests (2)

  • test_appsec_enabled - test_django_appsec_snapshots.py - Details

    Expand for error
     Unexpected test failure during snapshot test: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f51a2a521f0>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_appsec_enabled_attack - test_django_appsec_snapshots.py - Details

    Expand for error
     Unexpected test failure during snapshot test: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f51a0e07970>: Failed to establish a new connection: [Errno 111] Connection refused'))
    

Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/internal/core/crashtracking.py                                  @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2024-10-30 16:41:14

Comparing candidate commit 649de48 in PR branch backport-10720-to-2.11 with baseline commit 81e151f in branch 2.11.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants