Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iast): backport fix from 10706 to 2.12 #10736

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Sep 20, 2024

Description

Partial backport of the Initializer atexit fix from #10706.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added the ASM Application Security Monitoring label Sep 20, 2024
@juanjux juanjux self-assigned this Sep 20, 2024
@juanjux juanjux requested review from a team as code owners September 20, 2024 08:30
@juanjux juanjux changed the title Backport fix from 10706 fix(iast): backport fix from 10706 Sep 20, 2024
@juanjux juanjux changed the title fix(iast): backport fix from 10706 fix(iast): backport fix from 10706 to 2.12 Sep 20, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 20, 2024

Datadog Report

Branch report: juanjux/backport-10706-to-212
Commit report: 418f26a
Test service: dd-trace-py

✅ 0 Failed, 113199 Passed, 728 Skipped, 33m 22.11s Total duration (4m 51.34s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.12@ef14a85). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             2.12   #10736   +/-   ##
=======================================
  Coverage        ?    9.85%           
=======================================
  Files           ?     1410           
  Lines           ?   120861           
  Branches        ?        0           
=======================================
  Hits            ?    11914           
  Misses          ?   108947           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Benchmark execution time: 2024-09-20 09:05:07

Comparing candidate commit 418f26a in PR branch juanjux/backport-10706-to-212 with baseline commit ef14a85 in branch 2.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@juanjux juanjux merged commit 6423e01 into 2.12 Sep 20, 2024
259 of 265 checks passed
@juanjux juanjux deleted the juanjux/backport-10706-to-212 branch September 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants