Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pymongo): add testing to pymongo patch #10745

Merged
merged 26 commits into from
Sep 23, 2024
Merged

chore(pymongo): add testing to pymongo patch #10745

merged 26 commits into from
Sep 23, 2024

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Sep 20, 2024 •
edited
Loading

Tests patching and unpatching pymongo, following the new changes to add support for pymongo v4.9.1 in feat(pymongo): add support for v4.9

Additionally, adds fix for an issue with assert_wrapped that previously assumed wrapped object always comes from wrapt, when it can come from internal wrapping function.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

CODEOWNERS have been resolved as:

tests/contrib/patch.py                                                  @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pymongo/test.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pymongo/test_pymongo_patch.py                             @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 20, 2024 •
edited
Loading

Datadog Report

Branch report: quinna/add-tests-pymongo-patch
Commit report: d92d9b0
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 604 Skipped, 19m 0.47s Total duration (17m 24.89s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-09-23 21:48:55

Comparing candidate commit d92d9b0 in PR branch quinna/add-tests-pymongo-patch with baseline commit 3bffd02 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

@quinna-h quinna-h changed the title add testing to pymongo patch fix(pymongo): add testing to pymongo patch Sep 20, 2024
@quinna-h quinna-h marked this pull request as ready for review September 20, 2024 20:35
@quinna-h quinna-h requested review from a team as code owners September 20, 2024 20:35
@mabdinur mabdinur changed the base branch from main to munir/test-pymongo-4-9 September 20, 2024 20:49
@mabdinur mabdinur requested a review from a team as a code owner September 20, 2024 20:49
mabdinur
mabdinur reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits but overall looks great!

I updated the base branch from main to munir/test-pymongo-4-9. We should remove the kafka changes from this PR

@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 23, 2024
Base automatically changed from munir/test-pymongo-4-9 to main September 23, 2024 19:43
@quinna-h quinna-h changed the title fix(pymongo): add testing to pymongo patch chore(pymongo): add testing to pymongo patch Sep 23, 2024
mabdinur
mabdinur approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quinna-h quinna-h enabled auto-merge (squash) September 23, 2024 20:28
@quinna-h quinna-h merged commit 1e8ba1c into main Sep 23, 2024
568 checks passed
@quinna-h quinna-h deleted the quinna/add-tests-pymongo-patch branch September 23, 2024 21:50
mabdinur added a commit that referenced this pull request Sep 25, 2024
@quinna-h @mabdinur
chore(pymongo): add testing to pymongo patch (#10745)
42e47e3 
Tests patching and unpatching pymongo, following the new changes to add
support for pymongo v4.9.1 in [feat(pymongo): add support for
v4.9](#10718)

Additionally, adds fix for an issue with `assert_wrapped` that
previously assumed wrapped object always comes from `wrapt`, when it can
come from internal wrapping function.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <[email protected]>
Co-authored-by: Munir Abdinur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikayasuda erikayasuda erikayasuda approved these changes

@mabdinur mabdinur mabdinur approved these changes

@Yun-Kim Yun-Kim Awaiting requested review from Yun-Kim Yun-Kim was automatically assigned from DataDog/apm-python

@wconti27 wconti27 Awaiting requested review from wconti27 wconti27 is a code owner automatically assigned from DataDog/apm-idm-python

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinna-h @mabdinur @erikayasuda