Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): ensure http.url obfuscation is consistent with other libraries #10914

Merged
merged 9 commits into from
Oct 7, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Oct 2, 2024

When DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXP is set to an empty string global_query_string_obfuscation_disabled should be set to False.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Oct 2, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/make-obfuscation-consistent-8a2361bf3298e1be.yaml    @DataDog/apm-python
ddtrace/contrib/trace_utils.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/utils/http.py                                          @DataDog/apm-core-python
ddtrace/settings/config.py                                              @DataDog/python-guild @DataDog/apm-sdk-api-python
tests/tracer/test_env_vars.py                                           @DataDog/apm-sdk-api-python
tests/tracer/test_http.py                                               @DataDog/apm-sdk-api-python
tests/tracer/test_trace_utils.py                                        @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024

Benchmarks

Benchmark execution time: 2024-10-07 20:20:15

Comparing candidate commit 9dd715e in PR branch munir/make-obfuscation-consistent with baseline commit 2af13d9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@mabdinur mabdinur force-pushed the munir/make-obfuscation-consistent branch from 51344e1 to 31430bb Compare October 3, 2024 16:50
@mabdinur mabdinur force-pushed the munir/make-obfuscation-consistent branch from 31430bb to 60f4c1f Compare October 3, 2024 16:51
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 3, 2024

Datadog Report

Branch report: munir/make-obfuscation-consistent
Commit report: 9dd715e
Test service: dd-trace-py

✅ 0 Failed, 1156 Passed, 130 Skipped, 26m 57.51s Total duration (9m 56.68s time saved)

@mabdinur mabdinur force-pushed the munir/make-obfuscation-consistent branch from fd38bd5 to 69f94ac Compare October 3, 2024 22:29
@mabdinur mabdinur marked this pull request as ready for review October 3, 2024 22:34
@mabdinur mabdinur requested review from a team as code owners October 3, 2024 22:34
@mabdinur mabdinur force-pushed the munir/make-obfuscation-consistent branch from 4c5c079 to 0b535af Compare October 3, 2024 23:15
@mabdinur mabdinur enabled auto-merge (squash) October 3, 2024 23:15
ddtrace/settings/config.py Show resolved Hide resolved
@mabdinur mabdinur requested review from wconti27 and a team October 7, 2024 17:10
@mabdinur mabdinur merged commit 5f25f36 into main Oct 7, 2024
584 of 586 checks passed
@mabdinur mabdinur deleted the munir/make-obfuscation-consistent branch October 7, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants