Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pymongo): service name override in pymongo #10917

Merged
merged 15 commits into from
Oct 7, 2024

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Oct 2, 2024

This PR makes the following changes:

  • Setting config.pymongo['service'] did not override service name, due to previously having a Pin overriding. This changes the Pin on the MongoClienttoNone`
  • We should use ext_service instead of int_service for pymongo

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Oct 2, 2024

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/pymongo/client.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pymongo/patch.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pymongo/test.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python

@quinna-h quinna-h changed the title Fix service name override in pymongo chore(pymongo): service name override in pymongo Oct 2, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024

Benchmarks

Benchmark execution time: 2024-10-04 22:06:35

Comparing candidate commit 78b7ffe in PR branch quinna/pymongo-service-name-override with baseline commit e0dd63b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 299 metrics, 53 unstable metrics.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 4, 2024

Datadog Report

Branch report: quinna/pymongo-service-name-override
Commit report: 78b7ffe
Test service: dd-trace-py

✅ 0 Failed, 921 Passed, 275 Skipped, 24m 48.68s Total duration (10m 49.91s time saved)

@quinna-h quinna-h marked this pull request as ready for review October 4, 2024 21:23
@quinna-h quinna-h requested review from a team as code owners October 4, 2024 21:23
@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 4, 2024
@quinna-h quinna-h merged commit 6536952 into main Oct 7, 2024
583 of 589 checks passed
@quinna-h quinna-h deleted the quinna/pymongo-service-name-override branch October 7, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants