-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pymongo): service name override in pymongo #10917
Conversation
|
BenchmarksBenchmark execution time: 2024-10-04 22:06:35 Comparing candidate commit 78b7ffe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 299 metrics, 53 unstable metrics. |
Datadog ReportBranch report: ✅ 0 Failed, 921 Passed, 275 Skipped, 24m 48.68s Total duration (10m 49.91s time saved) |
This PR makes the following changes:
config.pymongo['service']
did not override service name, due to previously having aPin
overriding. This changes thePin
on the MongoClientto
None`ext_service
instead ofint_service
for pymongoChecklist
Reviewer Checklist