Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): remove IAST deny list elements #10961

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Oct 7, 2024

A memory leak was introduced in #10540 when "py" was removed from the deny list. This caused a leak in FastAPI with the pypika package. #10846 patched the issue, and #10947 resolved it. Now, we're re-enabling those packages.

This PR is tested in #10902

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_ast/ast_patching.py                               @DataDog/asm-python

@avara1986 avara1986 marked this pull request as ready for review October 7, 2024 13:13
@avara1986 avara1986 requested a review from a team as a code owner October 7, 2024 13:13
@avara1986 avara1986 enabled auto-merge (squash) October 7, 2024 14:22
@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Benchmarks

Benchmark execution time: 2024-10-07 20:19:26

Comparing candidate commit 88423d3 in PR branch avara1986/leak_hunt with baseline commit 2af13d9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 373 metrics, 53 unstable metrics.

@avara1986 avara1986 merged commit 885df93 into main Oct 8, 2024
570 of 571 checks passed
@avara1986 avara1986 deleted the avara1986/leak_hunt branch October 8, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants