Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iast): add google.auth and googlecloudsdk to the IAST denylist [backport 2.14] #11323

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Nov 7, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

…11305)

- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Signed-off-by: Juanjo Alvarez <[email protected]>
(cherry picked from commit 3cfe7dd)
@juanjux juanjux requested review from a team as code owners November 7, 2024 09:10
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/google-sdk-denylist-0619f1734507019a.yaml            @DataDog/apm-python
ddtrace/appsec/_iast/_ast/ast_patching.py                               @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Benchmarks

Benchmark execution time: 2024-11-12 09:45:53

Comparing candidate commit 368bfba in PR branch backport-11305-to-2.14 with baseline commit ba7ffce in branch 2.14.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 357 metrics, 47 unstable metrics.

@juanjux juanjux closed this Nov 7, 2024
@juanjux juanjux reopened this Nov 7, 2024
@juanjux juanjux closed this Nov 8, 2024
@juanjux juanjux reopened this Nov 8, 2024
@juanjux juanjux enabled auto-merge (squash) November 8, 2024 08:40
@juanjux juanjux closed this Nov 11, 2024
auto-merge was automatically disabled November 11, 2024 08:50

Pull request was closed

@juanjux juanjux reopened this Nov 11, 2024
@juanjux juanjux enabled auto-merge (squash) November 12, 2024 09:20
@juanjux juanjux merged commit bb5ec76 into 2.14 Nov 12, 2024
621 of 625 checks passed
@juanjux juanjux deleted the backport-11305-to-2.14 branch November 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants