Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): bump libdatadog version #11337

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Nov 8, 2024

This is a minor version bump for libdatadog. It doesn't really affect anything, except it fixes an issue with the crashtracker altstack creation not being sufficiently granular. This isn't a problem for Python, since we just use and create a sane default.

Still, if we ever need this to work properly during an investigation, it should be properly configurable.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sanchda sanchda requested a review from a team as a code owner November 8, 2024 15:39
@sanchda sanchda added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/cmake/FindLibdatadog.cmake           @DataDog/profiling-python
ddtrace/internal/datadog/profiling/cmake/tools/libdatadog_checksums.txt  @DataDog/profiling-python

@sanchda
Copy link
Contributor Author

sanchda commented Nov 8, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 8, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-08 15:39:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-08 19:26:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-11-08 19:59:33 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 4e100cd:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: sanchda/libdatadog_v14.1.0
Commit report: b5e966c
Test service: dd-trace-py

✅ 0 Failed, 942 Passed, 344 Skipped, 25m 9.69s Total duration (11m 45.78s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Benchmark execution time: 2024-11-11 20:13:25

Comparing candidate commit fa15138 in PR branch sanchda/libdatadog_v14.1.0 with baseline commit 69026ee in branch main.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 384 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟩 execution_time [-416.465ns; -352.590ns] or [-11.506%; -9.741%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟩 execution_time [-606.402ns; -530.173ns] or [-10.740%; -9.390%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-412.430ns; -351.310ns] or [-9.744%; -8.300%]

scenario:iast_aspects-rsplit_aspect

  • 🟩 execution_time [-198.029ns; -170.975ns] or [-10.209%; -8.814%]

@taegyunkim taegyunkim enabled auto-merge (squash) November 11, 2024 19:32
@taegyunkim taegyunkim merged commit 498e125 into main Nov 11, 2024
639 of 642 checks passed
@taegyunkim taegyunkim deleted the sanchda/libdatadog_v14.1.0 branch November 11, 2024 21:49
quinna-h pushed a commit that referenced this pull request Nov 13, 2024
This is a minor version bump for libdatadog. It doesn't really affect
anything, except it fixes an issue with the crashtracker altstack
creation not being sufficiently granular. This isn't a problem for
Python, since we just use and create a sane default.

Still, if we ever need this to work properly during an investigation, it
should be properly configurable.

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Taegyun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants