Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing server address tags to snapshot tests #11349

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Nov 11, 2024

Continuation of #10064 to add server.address tags to DB clients to comply with OTel standards.

Update django snapshot files, and modify the logic to set server_address using the existing internal method (for future instrumentations).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 11, 2024

CODEOWNERS have been resolved as:

ddtrace/contrib/trace_utils.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_psycopg2_query_default.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_psycopg3_query_default.json  @DataDog/apm-python

@quinna-h quinna-h changed the title Update snapshot tests server address feat: add server address tags to clients Nov 11, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 11, 2024

Datadog Report

Branch report: update-snapshot-tests-server-address
Commit report: 4e56dba
Test service: dd-trace-py

✅ 0 Failed, 1196 Passed, 0 Skipped, 30m 1.64s Total duration (7m 25.94s time saved)
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • test_unspecified_service_v1 - test_pymysql.py 5.44s (+4.87s, +856%) - Details

@quinna-h quinna-h changed the title feat: add server address tags to clients chore: add server address tags to clients Nov 11, 2024
@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 11, 2024
@quinna-h quinna-h marked this pull request as ready for review November 11, 2024 19:46
@quinna-h quinna-h changed the title chore: add server address tags to clients chore: add missing server address tags to snapshot tests Nov 11, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-12 15:58:12

Comparing candidate commit 4e56dba in PR branch update-snapshot-tests-server-address with baseline commit 66f7646 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 380 metrics, 2 unstable metrics.

@quinna-h quinna-h merged commit 9e7acd0 into main Nov 12, 2024
654 of 659 checks passed
@quinna-h quinna-h deleted the update-snapshot-tests-server-address branch November 12, 2024 17:00
quinna-h added a commit that referenced this pull request Nov 13, 2024
Continuation of #10064 to add `server.address` tags to DB clients to
comply with OTel standards.

Update `django` snapshot files, and modify the logic to set
`server_address` using the existing internal method (for future
instrumentations).

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants