-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing server address tags to snapshot tests #11349
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 1196 Passed, 0 Skipped, 30m 1.64s Total duration (7m 25.94s time saved) ⌛ Performance Regressions vs Default Branch (1)
|
BenchmarksBenchmark execution time: 2024-11-12 15:58:12 Comparing candidate commit 4e56dba in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 380 metrics, 2 unstable metrics. |
Continuation of #10064 to add `server.address` tags to DB clients to comply with OTel standards. Update `django` snapshot files, and modify the logic to set `server_address` using the existing internal method (for future instrumentations). ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Continuation of #10064 to add
server.address
tags to DB clients to comply with OTel standards.Update
django
snapshot files, and modify the logic to setserver_address
using the existing internal method (for future instrumentations).Checklist
Reviewer Checklist