-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): support listing headers in DD_TRACE_HEADER_TAGS without tag names #9589
Conversation
Datadog ReportBranch report: ❌ 62 Failed (0 Known Flaky), 144622 Passed, 31498 Skipped, 9h 40m 40.28s Total duration (1h 9m 45.04s time saved) ❌ Failed Tests (62)
|
Can you be sure to update this in the system tests as well? - https://github.com/DataDog/system-tests/blob/main/manifests/python.yml#L682 @mabdinur my link is outdated b/c the file changed, but it's the |
Datadog ReportBranch report: ❌ 2 Failed (0 Known Flaky), 144910 Passed, 31463 Skipped, 8h 11m 1.3s Total duration (1h 52m 52.11s time saved) ❌ Failed Tests (2)
|
f95edff
to
d778ad5
Compare
9b18f5a
to
0b4232c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9589 +/- ##
===========================================
- Coverage 73.93% 10.54% -63.39%
===========================================
Files 1402 1368 -34
Lines 130420 127993 -2427
===========================================
- Hits 96426 13502 -82924
- Misses 33994 114491 +80497 ☔ View full report in Codecov by Sentry. |
Co-authored-by: erikayasuda <[email protected]>
Co-authored-by: kyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
Datadog ReportBranch report: ✅ 0 Failed, 133542 Passed, 44232 Skipped, 6h 53m 9.08s Total duration (12m 3.16s time saved) |
…t tag names (#9589) This will align the implementation of DD_TRACE_HEADER_TAGS with the golang and java tracers. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <[email protected]> Co-authored-by: kyle <[email protected]>
This will align the implementation of DD_TRACE_HEADER_TAGS with the golang and java tracers.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist