-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test on 3.12 where appropriate #9703
Conversation
Datadog ReportBranch report: ❌ 41 Failed (0 Known Flaky), 175286 Passed, 1733 Skipped, 11h 53m 10.87s Total duration (17m 47.67s time saved) ❌ Failed Tests (41)
New Flaky Tests (40)
⌛ Performance Regressions vs Default Branch (1)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9703 +/- ##
===========================================
- Coverage 74.30% 10.55% -63.75%
===========================================
Files 1398 1368 -30
Lines 129930 127869 -2061
===========================================
- Hits 96541 13494 -83047
- Misses 33389 114375 +80986 ☔ View full report in Codecov by Sentry. |
Pull Request is not mergeable
Pull Request is not mergeable
@Yun-Kim could you give your opinion on the MLObs aspects of this change? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one request regarding a langchain venv being removed but otherwise happy to start testing on 3.12
Pull Request is not mergeable
Pull Request is not mergeable
This change updates many test suites to include Python 3.12 in their set of tested runtimes. The ones that haven't been updated in this way are those that appear to require code changes for 3.12 support to work. This change matters because 3.12 is among the officially supported runtimes by this library.
Most of the line changes in this diff are in generated riot lockfiles and can be ignored.
The removal of the snapshot assertion in the test harness made some asynchronous tests pass without breaking any others.
Checklist
Reviewer Checklist