chore(tracing): add span links and events to debug info #9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
commented
Jul 9, 2024
mabdinur
force-pushed
the
munir/add-span-events-to-span-finish-debug-logs
branch
from
c5617b3
to
6d946f1
Compare
Datadog ReportBranch report: ✅ 0 Failed, 174641 Passed, 2408 Skipped, 9h 1m 3.85s Total duration (6m 7.24s time saved) |
BenchmarksBenchmark execution time: 2024-07-24 17:39:49 Comparing candidate commit 8b66d74 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
mabdinur
added
the
changelog/no-changelog
brettlangdon
approved these changes
Jul 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9771 +/- ##
===========================================
- Coverage 74.66% 10.51% -64.15%
===========================================
Files 1391 1365 -26
Lines 128970 127671 -1299
===========================================
- Hits 96293 13430 -82863
- Misses 32677 114241 +81564 ☔ View full report in Codecov by Sentry. |
|
|
ZStriker19
approved these changes
Jul 24, 2024
gnufede
pushed a commit
that referenced
this pull request
Jul 26, 2024
`Span._pprint()` is used in span finish debug logs. This PR ensures span_links and span_events values are also printed. ## Checklist - [x] The PR description includes an overview of the change - [x] The PR description articulates the motivation for the change - [x] The change includes tests OR the PR description describes a testing strategy - [x] The PR description notes risks associated with the change, if any - [x] Newly-added code is easy to change - [x] The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - [x] The change includes or references documentation updates if necessary - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Title is accurate - [ ] All changes are related to the pull request's stated goal - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [ ] Testing strategy adequately addresses listed risks - [ ] Newly-added code is easy to change - [ ] Release note makes sense to a user of the library - [ ] If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span._pprint()is used in span finish debug logs. This PR ensures span_links and span_events values are also printed.Checklist
Reviewer Checklist