-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(botocore): add override service name to botocore integration #9856
Conversation
|
BenchmarksBenchmark execution time: 2024-07-18 21:24:11 Comparing candidate commit 11b474c in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 212 metrics, 2 unstable metrics. scenario:sethttpmeta-useragentvariant_exists_2
scenario:sethttpmeta-useragentvariant_exists_3
|
Datadog ReportBranch report: ✅ 0 Failed, 180 Passed, 783 Skipped, 7m 18.92s Total duration (23m 2.29s time saved) |
…ocore-service-naming' into quinna/AIDM-210/botocore-service-naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I will leave the official approval to IDM and MLObs since these are their files
…ocore-service-naming' into quinna/AIDM-210/botocore-service-naming
@DataDog/ml-observability Could we get a review on this PR? 🙏 The automation didn't automatically tag someone from the team for some reason. |
…9856) Motivation: Currently traces in botocore derive their service name from the service and endpoint, ex. `aws.s3` or `aws.sqs`, and there is no way to change the service name. Other integrations allow for changing the default service name either by setting environment variables, or configuring with `config['service']` or `config['service_name']`. This PR adds support for these methods of overriding the service name, which allows individual traces to have custom service names. Examples: ``` @mock_s3 ddtrace.config.botocore['service_name'] = "botocore" # this sets service name to botocore.s3 ddtrace.config.botocore['service'] = "boto-service" # this overrides previous and sets service name to boto-service.s3 ``` `export DD_BOTOCORE_SERVICE="boto" # this overrides previous settings and sets service & service name to boto.s3 ` ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Zachary Groves <[email protected]> Co-authored-by: erikayasuda <[email protected]> (cherry picked from commit 2bb0c4b)
…ckport 2.10] (#9894) Backport 2bb0c4b from #9856 to 2.10. Motivation: Currently traces in botocore derive their service name from the service and endpoint, ex. `aws.s3` or `aws.sqs`, and there is no way to change the service name. Other integrations allow for changing the default service name either by setting environment variables, or configuring with `config['service']` or `config['service_name']`. This PR adds support for these methods of overriding the service name, which allows individual traces to have custom service names. Examples: ``` @mock_s3 ddtrace.config.botocore['service_name'] = "botocore" # this sets service name to botocore.s3 ddtrace.config.botocore['service'] = "boto-service" # this overrides previous and sets service name to boto-service.s3 ``` `export DD_BOTOCORE_SERVICE="boto" # this overrides previous settings and sets service & service name to boto.s3 ` ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Quinna Halim <[email protected]>
Motivation:
Currently traces in botocore derive their service name from the service and endpoint, ex.
aws.s3
oraws.sqs
, and there is no way to change the service name. Other integrations allow for changing the default service name either by setting environment variables, or configuring withconfig['service']
orconfig['service_name']
. This PR adds support for these methods of overriding the service name, which allows individual traces to have custom service names.Examples:
export DD_BOTOCORE_SERVICE="boto" # this overrides previous settings and sets service & service name to boto.s3
Checklist
Reviewer Checklist