Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove another temporal in the propagation test #9870

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jul 18, 2024

Description

There was a missing temporal engine in the fixture for the propagation test that could make the test flaky if the temporal string address was reused and not expunged from the taint dictionary. This removed it and no more temporal should remain on the fixture.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jul 18, 2024
@juanjux juanjux self-assigned this Jul 18, 2024
@juanjux juanjux requested a review from a team as a code owner July 18, 2024 14:31
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/appsec/iast/fixtures/propagation_path.py                          @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jul 18, 2024

Datadog Report

Branch report: juanjux/iast-test-remove-temporal
Commit report: f09cd7e
Test service: dd-trace-py

✅ 0 Failed, 111774 Passed, 845 Skipped, 21m 32.8s Total duration (1m 32.11s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jul 18, 2024

Benchmarks

Benchmark execution time: 2024-07-18 15:04:43

Comparing candidate commit 45b8333 in PR branch juanjux/iast-test-remove-temporal with baseline commit 6bf5db3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 10.54%. Comparing base (c728c68) to head (25c4111).
Report is 51 commits behind head on main.

Files Patch % Lines
tests/appsec/iast/fixtures/propagation_path.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9870       +/-   ##
===========================================
- Coverage   74.30%   10.54%   -63.76%     
===========================================
  Files        1398     1368       -30     
  Lines      129930   127997     -1933     
===========================================
- Hits        96541    13500    -83041     
- Misses      33389   114497    +81108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanjux juanjux enabled auto-merge (squash) July 23, 2024 11:09
@juanjux juanjux merged commit 40ce686 into main Jul 23, 2024
68 of 71 checks passed
@juanjux juanjux deleted the juanjux/iast-test-remove-temporal branch July 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants