-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove another temporal in the propagation test #9870
Conversation
Signed-off-by: Juanjo Alvarez <[email protected]>
|
Datadog ReportBranch report: ✅ 0 Failed, 111774 Passed, 845 Skipped, 21m 32.8s Total duration (1m 32.11s time saved) |
BenchmarksBenchmark execution time: 2024-07-18 15:04:43 Comparing candidate commit 45b8333 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9870 +/- ##
===========================================
- Coverage 74.30% 10.54% -63.76%
===========================================
Files 1398 1368 -30
Lines 129930 127997 -1933
===========================================
- Hits 96541 13500 -83041
- Misses 33389 114497 +81108 ☔ View full report in Codecov by Sentry. |
Description
There was a missing temporal engine in the fixture for the propagation test that could make the test flaky if the temporal string address was reused and not expunged from the taint dictionary. This removed it and no more temporal should remain on the fixture.
Checklist
Reviewer Checklist