-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(asm): update libddwaf to 1.19.0 [backport 2.10] #9907
Conversation
update libddwaf to [1.19.0](https://github.com/DataDog/libddwaf/releases/tag/1.19.0) _no further changes in the tracer are required as this update does not contain any breaking changes._ Backporting to 2.10 to able the backend to test the new waf features while deploying 2.10rc on staging ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit cac5e29)
Datadog ReportBranch report: ✅ 0 Failed, 175382 Passed, 1181 Skipped, 11h 39m 26.63s Total duration (19m 31.74s time saved) ⌛ Performance Regressions vs Default Branch (2) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #9907 +/- ##
===========================================
- Coverage 27.69% 10.16% -17.53%
===========================================
Files 1309 1306 -3
Lines 124119 124359 +240
===========================================
- Hits 34371 12646 -21725
- Misses 89748 111713 +21965 ☔ View full report in Codecov by Sentry. |
Backport cac5e29 from #9906 to 2.10.
update libddwaf to 1.19.0
no further changes in the tracer are required as this update does not contain any breaking changes.
Backporting to 2.10 to able the backend to test the new waf features while deploying 2.10rc on staging
APPSEC-54212
Checklist
Reviewer Checklist