Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): update libddwaf to 1.19.0 [backport 2.10] #9907

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 23, 2024

Backport cac5e29 from #9906 to 2.10.

update libddwaf to 1.19.0

no further changes in the tracer are required as this update does not contain any breaking changes.

Backporting to 2.10 to able the backend to test the new waf features while deploying 2.10rc on staging

APPSEC-54212

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

update libddwaf to
[1.19.0](https://github.com/DataDog/libddwaf/releases/tag/1.19.0)

_no further changes in the tracer are required as this update does not
contain any breaking changes._

Backporting to 2.10 to able the backend to test the new waf features
while deploying 2.10rc on staging

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit cac5e29)
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jul 23, 2024
@github-actions github-actions bot requested review from a team as code owners July 23, 2024 09:54
@christophe-papazian christophe-papazian enabled auto-merge (squash) July 23, 2024 09:54
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-9906-to-2.10
Commit report: 832c243
Test service: dd-trace-py

✅ 0 Failed, 175382 Passed, 1181 Skipped, 11h 39m 26.63s Total duration (19m 31.74s time saved)
⌛ 2 Performance Regressions

⌛ Performance Regressions vs Default Branch (2)

  • test_user_specified_service - test_jinja2.py 3.39s (+2.72s, +405%) - Details
  • test_schematized_operation_name[v0] - test_request.py 6.34s (+5.3s, +508%) - Details

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.16%. Comparing base (23e1da9) to head (832c243).
Report is 17 commits behind head on 2.10.

Additional details and impacted files
@@             Coverage Diff             @@
##             2.10    #9907       +/-   ##
===========================================
- Coverage   27.69%   10.16%   -17.53%     
===========================================
  Files        1309     1306        -3     
  Lines      124119   124359      +240     
===========================================
- Hits        34371    12646    -21725     
- Misses      89748   111713    +21965     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Jul 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 23, 2024

Benchmarks

Benchmark execution time: 2024-07-23 10:47:52

Comparing candidate commit 832c243 in PR branch backport-9906-to-2.10 with baseline commit aa5615a in branch 2.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

auto-merge was automatically disabled July 23, 2024 10:51

Pull request was closed

@christophe-papazian christophe-papazian enabled auto-merge (squash) July 23, 2024 10:51
@christophe-papazian christophe-papazian merged commit 7ea31c5 into 2.10 Jul 23, 2024
140 of 152 checks passed
@christophe-papazian christophe-papazian deleted the backport-9906-to-2.10 branch July 23, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants