-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracer): use simple queue file for extra service names instead of multiprocessing [backport 2.10] #9910
Conversation
…of multiprocessing (#9701) To prevent further problems with multiprocessing in config: - remove multiprocessing queue from main config file - add a new File_Queue using low level locking to write into temporary file - Use the new queue to exchange messages between multiple processes for extra service names - update tests - added a new unit-tests workflow on github to launch any tests on linux(x86), macos(arm64) and windows(x86). (For now, only the test relevant to that PR is used). This is an alternative solution to #9626 ensuring that we still report extra service names. [APPSEC-53927] - [x] The PR description includes an overview of the change - [x] The PR description articulates the motivation for the change - [x] The change includes tests OR the PR description describes a testing strategy - [x] The PR description notes risks associated with the change, if any - [x] Newly-added code is easy to change - [x] The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - [x] The change includes or references documentation updates if necessary - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Newly-added code is easy to change - [x] Release note makes sense to a user of the library - [x] If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) [APPSEC-53927]: https://datadoghq.atlassian.net/browse/APPSEC-53927?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ (cherry picked from commit f85625a)
BenchmarksBenchmark execution time: 2024-07-23 18:18:47 Comparing candidate commit 6aa2384 in PR branch Found 7 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 9 unstable metrics. scenario:httppropagationextract-full_t_id_datadog_headers
scenario:otelspan-add-metrics
scenario:otelspan-add-tags
scenario:ratelimiter-high_rate_limit
scenario:ratelimiter-low_rate_limit
scenario:span-add-metrics
scenario:span-add-tags
|
Datadog ReportBranch report: ✅ 0 Failed, 117592 Passed, 59066 Skipped, 4h 19m 43.18s Total duration (54m 26.82s time saved) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #9910 +/- ##
===========================================
- Coverage 27.69% 10.21% -17.48%
===========================================
Files 1309 1309
Lines 124119 124564 +445
===========================================
- Hits 34371 12725 -21646
- Misses 89748 111839 +22091 ☔ View full report in Codecov by Sentry. |
…of multiprocessing (#9701)
To prevent further problems with multiprocessing in config:
This is an alternative solution to
#9626 ensuring that we still report extra service names.
APPSEC-53927
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance
policy
(cherry picked from commit f85625a)
Checklist
Reviewer Checklist