chore(langchain): update latest langchain test version [backport #9902 to 2.10] #9914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Kim
added
the
changelog/no-changelog
Yun-Kim
force-pushed
the
yunkim/backport-9902-to-210
branch
2 times, most recently
from
17cb5e5
to
000c88a
Compare
This PR updates the langchain test suite to use the latest langchain version. Note that the latest langchain version [adds](https://github.com/langchain-ai/langchain/pull/23691/files) a few properties to the BaseLLM/ChatModel classes, which means the latest version tests will see more span tags than previously. To avoid further splitting of the test cassettes/snapshots in this test suite, I have marked these extra tags to be ignored. This is not a breaking change, just updating test versions and to avoid breaking CI. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Yun-Kim
force-pushed
the
yunkim/backport-9902-to-210
branch
from
000c88a
to
55e5ca3
Compare
Datadog ReportBranch report: ✅ 0 Failed, 175492 Passed, 1786 Skipped, 12h 4m 5.82s Total duration (13m 3.14s time saved) ⌛ Performance Regressions vs Default Branch (2) |
lievan
approved these changes
Jul 23, 2024
BenchmarksBenchmark execution time: 2024-07-24 19:09:59 Comparing candidate commit 98467d9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #9902 to 2.10.
This PR updates the langchain test suite to use the latest langchain version. Note that the latest langchain version
adds a few properties to the BaseLLM/ChatModel classes, which means the latest version tests will see more span tags than previously. To avoid further splitting of the test cassettes/snapshots in this test suite, I have marked these extra tags to be ignored. This is not a breaking change, just updating test versions and to avoid breaking CI.
Checklist
Reviewer Checklist