-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: privatizing methods in tornado,unittest,urllib,urllib3,vertica #9928
chore: privatizing methods in tornado,unittest,urllib,urllib3,vertica #9928
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 799 Passed, 35 Skipped, 3m 15.23s Total Time |
BenchmarksBenchmark execution time: 2024-07-30 15:50:16 Comparing candidate commit 7e22f2a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
…e7bd8f5613323.yaml
...notes/notes/deprecate-patch-py-methods-tornado-unittest-urllib-vertica-7e5e7bd8f5613323.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could we just update the PR name to reflect the various integrations modified here?
…e7bd8f5613323.yaml
The API should just be what is necessary. A lot of integrations expose implementation details through the patch.py We can’t just remove these functions right away as it will break our API so for each we will need to deprecate first and then remove in 2.x.
Checklist
Reviewer Checklist