Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(opentelemetry): pin opentelemetry-api version to unblock tests [backport 2.9] #9937

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 25, 2024

Backport 27cd94c from #9932 to 2.9.

Resolves the following failures: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED in ci.

The opentelemetry-api broke compatibility with ddtrace in v1.25.0 and then introduced another breaking change in 1.26.0. This PR ensures the telemetry test suite uses a stable version of the opentelemetry-api.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

)

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 27cd94c)
@github-actions github-actions bot requested review from a team as code owners July 25, 2024 14:47
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 25, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jul 25, 2024

Datadog Report

Branch report: backport-9932-to-2.9
Commit report: 1e8850b
Test service: dd-trace-py

✅ 0 Failed, 174257 Passed, 1508 Skipped, 11h 39m 27.77s Total duration (2m 49.72s time saved)
❄️ 1 New Flaky
⌛ 1 Performance Regression

New Flaky Tests (1)

  • test_span_schematization[None-v0] - test_graphql.py - Last Failure

    Expand for error
     sent 629B in 1.14308s to http://localhost:9126/v0.5/traces
       
     assert b'sent 629B i...v0.5/traces\n' == b''
       Use -v to get more diff
    

⌛ Performance Regressions vs Default Branch (1)

  • test_schematized_operation_names[v0] - test_djangorestframework.py 6.99s (+5.6s, +403%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Jul 25, 2024

Benchmarks

Benchmark execution time: 2024-07-25 15:50:29

Comparing candidate commit 1e8850b in PR branch backport-9932-to-2.9 with baseline commit 7ee32df in branch 2.9.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 193 metrics, 9 unstable metrics.

@mabdinur mabdinur closed this Jul 25, 2024
@mabdinur mabdinur reopened this Jul 25, 2024
@mabdinur mabdinur enabled auto-merge (squash) July 25, 2024 16:32
@mabdinur mabdinur merged commit d92891f into 2.9 Jul 25, 2024
136 checks passed
@mabdinur mabdinur deleted the backport-9932-to-2.9 branch July 25, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants