-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: privatizing methods kafka,kombu,langchain,logbook,logging,loguru #9946
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 2960 Passed, 470 Skipped, 37m 26.69s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9946 +/- ##
===========================================
- Coverage 73.90% 10.54% -63.36%
===========================================
Files 1402 1368 -34
Lines 130341 128047 -2294
===========================================
- Hits 96324 13503 -82821
- Misses 34017 114544 +80527 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-07-29 23:06:26 Comparing candidate commit 37932c6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
The API should just be what is necessary. A lot of integrations expose implementation details through the patch.py We can’t just remove these functions right away as it will break our API so for each we will need to deprecate first and then remove in 2.x.
Checklist
Reviewer Checklist