Adjust OTel Spec for new Ruby 3.4 syntax #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-11-12 19:17:51 Comparing candidate commit 2bd29cd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
sarahchen6
force-pushed
the
sarahchen6/adjust-otel-spec
branch
from
9e62d92
to
cc8edd4
Compare
TonyCTHsu
approved these changes
Nov 11, 2024
Strech
approved these changes
Nov 12, 2024
sarahchen6
force-pushed
the
sarahchen6/adjust-otel-spec
branch
from
cc8edd4
to
2bd29cd
Compare
p-datadog
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4094 +/- ##
==========================================
+ Coverage 97.74% 97.79% +0.04%
==========================================
Files 1341 1341
Lines 80356 80408 +52
Branches 4030 4048 +18
==========================================
+ Hits 78541 78632 +91
+ Misses 1815 1776 -39 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the beginning ":in `" in three tests.
Motivation:
Ruby 3.4 changes ` to ' at the beginning of strings. See here. This PR adjusts our spec to account for this change.
Change log entry
No change log needed.
Additional Notes:
How to test the change?
Green CI.