Add method name into telemetry in Context#run #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strech
added
the
dev/internal
y9v
approved these changes
Nov 12, 2024
BenchmarksBenchmark execution time: 2024-11-14 10:41:52 Comparing candidate commit 7d00da8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
TonyCTHsu
approved these changes
Nov 12, 2024
p-datadog
approved these changes
Nov 12, 2024
p-datadog
approved these changes
Nov 12, 2024
vpellan
approved these changes
Nov 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4103 +/- ##
==========================================
+ Coverage 97.77% 97.78% +0.01%
==========================================
Files 1350 1350
Lines 81076 81076
Branches 4085 4085
==========================================
+ Hits 79271 79283 +12
+ Misses 1805 1793 -12 ☔ View full report in Codecov by Sentry. |
Strech
deleted the
appsec-55802-add-method-name-to-libddwaf-debug-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add method name into the error message for telemetry logs.
Motivation:
As a workaround until we align telemetry to the error tracking we want to filter telemetry logs better.
Change log entry
No.
Additional Notes:
Existing monitor should be adjusted accordingly after release.
How to test the change?
CI is enough.