Add Ruby 3.4 support to CircleCI #4114
Open
+1,020
−441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-11-14 22:40:05 Comparing candidate commit 80fea2e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
sarahchen6
force-pushed
the
sarahchen6/circleci-take-3
branch
3 times, most recently
from
b58cf80
to
839fee9
Compare
p-datadog
reviewed
Nov 14, 2024
sarahchen6
force-pushed
the
sarahchen6/circleci-take-3
branch
from
be10925
to
466597d
Compare
sarahchen6
force-pushed
the
sarahchen6/circleci-take-3
branch
from
6154a21
to
f460d38
Compare
p-datadog
reviewed
Nov 14, 2024
sarahchen6
force-pushed
the
sarahchen6/circleci-take-3
branch
from
36798ce
to
32fe226
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4114 +/- ##
==========================================
+ Coverage 97.77% 97.78% +0.01%
==========================================
Files 1350 1350
Lines 81077 81167 +90
Branches 4085 4100 +15
==========================================
+ Hits 79275 79372 +97
+ Misses 1802 1795 -7 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 14, 2024
TonyCTHsu
approved these changes
Nov 14, 2024
marcotc
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds Ruby 3.4 to CircleCI.
Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add support for Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.
Change log entry
Ruby 3.4.0-preview2 is now supported.
Additional Notes:
This PR acts alongside #4038 and #4039 to add Ruby 3.4 support and combines #4095 and #4111 .
How to test the change?
Green CI.