Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.58.x] [NDMII-3054] enrich cisco aci metrics with user tags #18524

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

datadog-agent-integrations-bot[bot]
Copy link
Contributor

Backport 34e59e5 from #18496.


What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

* tag cisco_aci metrics with device and interfaces user tags

(cherry picked from commit 34e59e5)
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (7.58.x@b9f9aa7). Learn more about missing BASE report.

Additional details and impacted files
Flag Coverage Δ
cisco_aci 94.93% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 merged commit 669c628 into 7.58.x Sep 6, 2024
32 checks passed
@steveny91 steveny91 deleted the backport-18496-to-7.58.x branch September 6, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants