Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEMINT-122] DDSaaS: Brevo: Integration v1.0.0 #18564

Merged
merged 56 commits into from
Dec 19, 2024
Merged

[SIEMINT-122] DDSaaS: Brevo: Integration v1.0.0 #18564

merged 56 commits into from
Dec 19, 2024

Conversation

rajshah-crest
Copy link
Contributor

What does this PR do?

This is a initial release PR of Brevo integration including all the required assets i.e. Pipeline, Dashboard and Monitors

Additional Notes

  • This integration is webhook based and so Crawler will not be used.
  • Datadog team will be required to add UI component for generation of webhook URLs in the configuration tile. Two URLs will be created, with both URLs having the ddsource query parameter set to brevo. The service query parameter will be set to marketing-events for marketing events and transactional-events for transactional events.
  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/ label to the PR and it will automatically open a backport PR once this one is merged

@rajshah-crest rajshah-crest marked this pull request as ready for review September 13, 2024 12:17
@rajshah-crest rajshah-crest requested a review from a team as a code owner September 13, 2024 12:17
@apiazza-dd
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-19 20:17:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-19 21:29:37 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@apiazza-dd apiazza-dd requested review from bparmar-crest and removed request for bparmar-crest December 19, 2024 20:35
apiazza-dd
apiazza-dd approved these changes Dec 19, 2024
View reviewed changes
brevo/README.md
### Configuration

#### Webhook configuration for marketing events
Configure the Datadog endpoint to forward Brevo marketing events as logs to Datadog. For more details, see the Brevo [Marketing webhooks][3] documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this as is and then make the changes myself so I don't block you from testing.

@apiazza-dd
Copy link
Contributor

/merge -c

@apiazza-dd
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-19 21:29:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-19 21:40:35 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@apiazza-dd apiazza-dd added this pull request to the merge queue Dec 19, 2024
Merged via the queue into DataDog:master with commit 8c575d7 Dec 19, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
@github-merge-queue @bparmar-crest
[SIEMINT-122] DDSaaS: Brevo: Integration v1.0.0 (#18564)
3910e7c 
* brevo integration project skeleton

* brevo.svg added

* added all assets and modified readme, manifest files

* added more samples

* minor correction in sample

* changed dashboards, corrections in readme,manifest

* to resolve failed checks

* dashboard and pipeline changes

* minor corrections

* fixing pipeline failure

* fixing pipeline failure

* fixing pipeline failure

* Updated Dashboard and Pipeline

* fixing pipeline failure

* minor corrections in dashboard and pipeline

* minor dashbaord changes

* minor dashbaord change

* Update README and monitor descriptions

* Fix character limit issue in monitor descriptions

* minor change in dashboards

* change in dashboard and pipeline

* fix pipeline failure

* change in dashboard

* changed image and modified monitor content

* Updated monitor description and title

* whitespace omitted

* Modified sample logs for transactional events

* Fix log samples failure

* CODEOWNERS

* Integration name removed from monitors

* review comments incorporated

* README.md modified

---------

Co-authored-by: Bhavik Parmar <[email protected]>
Co-authored-by: Bhavik Parmar <[email protected]>
Co-authored-by: apiazza-dd <[email protected]> 8c575d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultkrebs thibaultkrebs thibaultkrebs approved these changes

@apiazza-dd apiazza-dd apiazza-dd approved these changes

@bparmar-crest bparmar-crest bparmar-crest approved these changes

@estherk15 estherk15 estherk15 approved these changes

@steveny91 steveny91 steveny91 approved these changes

Assignees
No one assigned
Labels
agent/approved assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging changelog/no-changelog crest/asset-pr dev/testing dev/tooling docs/approved documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor mergequeue-status: done product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/documentation team/logs-backend team/siem-logs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajshah-crest @thibaultkrebs @apiazza-dd @bparmar-crest @steveny91 @estherk15 @dj0well